Re: [Tyrel Datwyler] Re: [PATCH v2 6/7] ibmvfc: register and use asynchronous sub-queue

Konstantin Ryabitsev <[email protected]> writes:

> On Mon, Jun 15, 2026 at 04:14:48PM -0500, Dave Marquardt wrote:
>> 
>> Hi Konstantin. I'm using b4 to send patch series. I get these comments
>> about not having a Signed-off-by: tag. Should the tag be added by b4? Or
>> should the patch attestation be enough?
>
> That's not really the right way to put it. Different projects will have
> different DCO requirements and it's not up to b4 to enforce the presence of
> trailers. It's not the same as patch attestation -- the attestation's job is
> to mechanically attest that the patches haven't been tampered since they left
> your system. The Signed-off-by: trailer is more about the actual code you're
> committing.
>
>> I do notice that "b4 prep --check" flags some patches as missing the
>> Signed-off-by: tag, particularly when I've chosen to not fix some
>> warnings.
>
> It's speaking to you, then! :)
>
> You can either manually run all commits with -s (which is what I do), or you
> can set up a hook to do that for you automatically -- but since it's supposed
> to be a deliberate action by the committer, I recommend just always
> remembering to add that little "-s" after "git commit".

Thanks. I searched and searched the b4 documentation, and now, from your
explanation, understand why I don't see anything about Signed-off-by:
when submitting a patch series. Would it be worth adding something to
the manual? (Yes, if so, I'm volunteering :) )

-Dave