Re: [Tyrel Datwyler] Re: [PATCH v2 6/7] ibmvfc: register and use asynchronous sub-queue
Konstantin Ryabitsev <[email protected]> Wed, 17 Jun 2026 17:17:27 -0400
| Newsgroups | org.kernel.linux.tools |
|---|---|
| Message-ID | <20260617-true-spiked-wallaby-4834ad@meerkat> |
On Tue, Jun 16, 2026 at 07:52:36AM -0500, Dave Marquardt wrote: > > You can either manually run all commits with -s (which is what I do), or you > > can set up a hook to do that for you automatically -- but since it's supposed > > to be a deliberate action by the committer, I recommend just always > > remembering to add that little "-s" after "git commit". > > Thanks. I searched and searched the b4 documentation, and now, from your > explanation, understand why I don't see anything about Signed-off-by: > when submitting a patch series. Would it be worth adding something to > the manual? (Yes, if so, I'm volunteering :) ) I don't think so. The Signed-off-by: is common, but not at all a requirement, and since enabling/adding it must be a deliberate and well-understood decision by the commit author, I don't think it belongs in b4. I know we can spell it out in the b4 docs, but I don't know if people are going to be more likely to read them as opposed to the actual kernel documentation. -K