Re: [PATCH b4 0/3] review-tui: align take->merge with b4 shazam

Konstantin Ryabitsev <[email protected]> Mon, 22 Jun 2026 15:57:28 +0000

Newsgroups	org.kernel.linux.tools
Message-ID	<178214384853.1406066.9646416635712281426.b4-ty@b4>

On Mon, 22 Jun 2026 14:20:42 +0200, Christian Brauner wrote:
> review-tui: align take->merge with b4 shazam
> 
> The review TUI's "take" action (merge method) applies a reviewed series to
> a target branch, but it had drifted from how `b4 shazam` behaves on the
> command line in two annoying ways.
> 
> It ignored b4.shazam-merge-flags entirely, so --log, --stat and --gpg-sign
> had no effect from the TUI, and because the cover was composed in b4's own
> editor and then committed with `git merge --no-edit`, git never got a
> chance to apply those flags or to show the --log shortlog for review.
> 
> [...]

Applied, thanks!

[1/3] review-tui: honor shazam-merge-flags in take->merge
      commit: 5f7ee8ddacea7cf1cc8df76686f7d0eb088adb4a
[2/3] review-tui: run take->merge in the target branch's worktree
      commit: db9a629c3e959e6a437f2e1a24a506151aa04565
[3/3] review-tui: test shazam-merge-flags and worktree resolution
      commit: cfbfa5d163d6016cae0eeff9033b416c006db968

Best regards,
-- 
Konstantin Ryabitsev <[email protected]>