Re: [PATCH RFC 0/2] review-tui: add a "cherry-pick + merge" take method

> The review TUI's Take dialog can apply a series three ways: merge (a
> cover-letter merge commit of the whole series), linear (git am onto the
> target branch), or cherry-pick (pick a subset and git am it). It could
> not do the combination a maintainer often wants: take a hand-picked
> subset of a series *and* record it as a cover-letter merge commit -- the
> equivalent of "b4 shazam -M -P".

I don't have any specific objections to this series, especially since it
covers a workflow gap that is useful to you.

> That path was already half-wired. When some patches were marked skipped,
> the "merge" method fell through to the patch picker and merged just the
> non-skipped patches -- _do_take_merge already builds its mbox from a
> cherry-pick selection. But with nothing pre-skipped there was no way to
> ask for it: "merge" always took the whole series.

Yes, in my mind the skipping would have been done in the review app, but
if this speeds things up for a busy maintainer, then I'm happy to also
let this happen in the take process.

> ci.sh checkers (ruff format/check, ty) are clean on the changed sources,
> and the tui-tracking, tui-modals, tui-review, and three-way-merge suites
> pass (213 tests).

This phrasing looks familiar, so I do suggest that you add
"Assisted-by:" trailers when you rely on an LLM agent, if only for
stats-gathering reasons. :)

Reviewed-by: Konstantin Ryabitsev <[email protected]>

-- 
Konstantin Ryabitsev <[email protected]>