Re: [PATCH b4 0/2] review-tui: don't gpg-sign throwaway test-apply commits

Nicolas Schier <[email protected]> Thu, 23 Jul 2026 17:33:15 +0200
Newsgroups org.kernel.linux.tools
Message-ID <amI0O4M8Ie4qK9Yk@levanger>
On Thu, Jul 23, 2026 at 10:33:34AM +0200, Christian Brauner wrote:
> The take/rebase/target/base modals check whether a series applies
> cleanly by running a real git-am into a temporary worktree and rebase
> additionally probes with a cherry-pick. The four modal probes run from
> worker threads while the TUI keeps the terminal.
> 
> With commit.gpgsign=true and pinentry-curses git tries to sign every
> probe commit. pinentry then pops up on the tty that Textual owns in raw
> mode. The TUI repaints over the PIN dialog and its input reader swallows
> the keystrokes and so gpg never gets the PIN and the apply hangs. With a
> card-backed key this reproduces on every take.

yes, thanks a lot!

Tested-by: Nicolas Schier <[email protected]>