Re: [PATCH b4 0/2] review-tui: don't gpg-sign throwaway test-apply commits

On 2026-07-23 10:33 +0200, Christian Brauner wrote:
> The take/rebase/target/base modals check whether a series applies
> cleanly by running a real git-am into a temporary worktree and rebase
> additionally probes with a cherry-pick. The four modal probes run from
> worker threads while the TUI keeps the terminal.
> 
> With commit.gpgsign=true and pinentry-curses git tries to sign every
> probe commit. pinentry then pops up on the tty that Textual owns in raw
> mode. The TUI repaints over the PIN dialog and its input reader swallows
> the keystrokes and so gpg never gets the PIN and the apply hangs. With a
> card-backed key this reproduces on every take.
> 
> The probe commits are discarded together with the temporary worktree
> so signing them is pure waste. Let's pass -c commit.gpgsign=false to all
> five probes. The rebase cherry-pick runs under suspend() and so cannot
> deadlock. But its commits are just as throwaway. Real applies (checkout,
> take, rebase, merge) are unaffected. They run with the TUI suspended,
> where pinentry works, and keep signing per the user's configuration.
> 
> Signed-off-by: Christian Brauner (Amutable) <[email protected]>
> ---

It would be nice to get this issue fixed as I have to keep the patch on
my local b4 source to be able to use b4 review tui and I would like to
get rid of carrying that change (or something else that fixes it)
locally. :)

Thanks!
Christian