Re: [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
Uwe Kleine-König <[email protected]>
| Newsgroups | org.kernel.linux.tools,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <anqsTVj5QGYGiEQ9@monoceros> |
Hello, On Wed, Jun 03, 2026 at 07:09:09PM +0300, Francis Laniel wrote: > All types in `bindings` implement `Zeroable` if they can, so use > `pin_init::zeroed` instead of relying on `unsafe` code. > > If this ends up not compiling in the future, something in bindgen or on > the C side changed and is most likely incorrect. > > Suggested-by: Benno Lossin <[email protected]> > Link: https://github.com/Rust-for-Linux/linux/issues/1189 > Reviewed-by: Alexandre Courbot <[email protected]> > Acked-by: Michal Wilczynski <[email protected]> > Signed-off-by: Francis Laniel <[email protected]> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next for the 7.3 merge window. b4 behaved strange on that patch: $ b4 am -s -l -t -3 [email protected] Grabbing thread from lore.kernel.org/all/[email protected]/t.mbox.gz Analyzing 2 messages in the thread Looking for additional code-review trailers on lore.kernel.org Analyzing 23 code-review messages Checking attestation on all messages, may take a moment... --- ✓ [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed` + Link: https://patch.msgid.link/[email protected] + Signed-off-by: Uwe Kleine-König <[email protected]> --- ✓ Signed: DKIM/privacyrequired.com --- Total patches: 1 --- NOTE: some trailers ignored due to from/email mismatches: ! Trailer: Suggested-by: Benno Lossin <[email protected]> Msg From: Miguel Ojeda <[email protected]> ! Trailer: Acked-by: Michal Wilczynski <[email protected]> Msg From: Miguel Ojeda <[email protected]> ! Trailer: Signed-off-by: Francis Laniel <[email protected]> Msg From: Miguel Ojeda <[email protected]> ! Trailer: Reviewed-by: Alexandre Courbot <[email protected]> Msg From: Miguel Ojeda <[email protected]> NOTE: Rerun with -S to apply them anyway Preparing fake-am for v3: rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed` range: 2707b9df955d..81c3f2b030a1 Preared a fake commit range for 3-way merge (2707b9df955d..81c3f2b030a1) --- Link: https://patch.msgid.link/[email protected] Base: applies clean to current tree git checkout -b v3_20260603_laniel_francis_privacyrequired_com HEAD git am -3 ./v3_20260603_laniel_francis_rust_pwm_replace_core_mem_zeroed_with_pin_init_zeroed.mbx I didn't research what went wrong there and the trailer made it into the patch anyhow and adding -S doesn't change the patch. I added the [email protected] mailing list to Cc:, maybe someone there wants to debug that. Best regards and thanks for your contribution, Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmp6rW4ACgkQj4D7WH0S /k5X3gf/QUmCyjMrC2Fk6jUUaUmXgE6LT16a6QZbJ8dmdXdmrkS3p3mxsAxoN8Y9 3/1tYxROZ53L/w7b6se8OyJn3BhceXxtMBm9etU0yZq4ghNNCozZs9X8JQbcbWTw DW6TZ6/me7SzDeKWauRqQ4i0iKNqLTjMW60kNTJ45j8emOe8omzyAr7Yb6/lTz2V sWxelJ4Ej+h6SDfpu6OY/S6UfpkU/jKL69N4zkTN5TvLPZFA8sV8zLMYddsBKf24 NW0qwIeIRG7qzq2SQnk+eZOai60fkrFKS0b3RxzB1bMs+i2EQgHkL3j6k5j8XVaT qNIvRLX+4YqQjcJdSzmw82tEe0YdMQ== =Dcui -----END PGP SIGNATURE-----