Re: [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
Konstantin Ryabitsev <[email protected]>
| Newsgroups | org.kernel.linux.tools,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <20260811-famous-convivial-iguana-d4b104@meerkat> |
On Tue, Aug 11, 2026 at 11:00:54PM +0200, Miguel Ojeda wrote:
> > I added a special case where we ignore trailers we find in the follow-up if
> > these trailers already exist in the patch anyway, so, at least for this
> > particular case, the problem shouldn't resurface.
>
> Hmm... I usually indent with 2 or 4 spaces my "non-tags" to
> distinguish them from actual tags; perhaps I should mark them
> differently? Is there a "standard" prefix to ignore them instead of
> several spaces?
Unfortunately, some prominent maintainers indent their code review trailers,
which is why we have to pay attention to those.
I generally recommend using "|" when adding trailers that aren't part of
actual code review, e.g.:
| Fixes: abcde12345 ("Foo bar baz")
| Reviewed-by: Alex Dev <[email protected]>
These are guaranteed to be ignored.
-K