b4 review crash

Mark Brown <[email protected]> Thu, 13 Aug 2026 17:54:25 +0100
Newsgroups	org.kernel.linux.tools
Message-ID	<[email protected]>
Hi Konstantin,

When attempting to review:

   https://patch.msgid.link/[email protected]

which does not have a branch created yet I get:

Task exception was never retrieved
future: <Task finished name='None' coro=<Worker._run() done, defined at /home/broonie/git/b4/.venv/lib/python3.13/site-packages/textual/worker.py:358> exception=SystemExit(1)>
Traceback (most recent call last):
  File "/home/broonie/git/b4/.venv/bin/b4", line 10, in <module>
    sys.exit(cmd())
             ~~~^^
  File "/home/broonie/git/b4/src/b4/command.py", line 1368, in cmd
    cmdargs.func(cmdargs)
    ~~~~~~~~~~~~^^^^^^^^^
  File "/home/broonie/git/b4/src/b4/command.py", line 234, in cmd_review
    b4.review.main(cmdargs)
    ~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/broonie/git/b4/src/b4/review/_review.py", line 468, in main
    cmd_tui(cmdargs)
    ~~~~~~~^^^^^^^^^
  File "/home/broonie/git/b4/src/b4/review/_review.py", line 3080, in cmd_tui
    run_tracking_tui(
    ~~~~~~~~~~~~~~~~^
        identifier,
        ^^^^^^^^^^^
    ...<2 lines>...
        no_mouse=cmdargs.no_mouse,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/broonie/git/b4/src/b4/review_tui/_entry.py", line 145, in run_tracking_tui
    branch_name = app.run(mouse=use_mouse)
  File "/home/broonie/git/b4/.venv/lib/python3.13/site-packages/textual/app.py", line 2350, in run
    return asyncio.run(run_app())
           ~~~~~~~~~~~^^^^^^^^^^^
  File "/usr/lib/python3.13/asyncio/runners.py", line 195, in run
    return runner.run(main)
           ~~~~~~~~~~^^^^^^
  File "/usr/lib/python3.13/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/usr/lib/python3.13/asyncio/base_events.py", line 712, in run_until_complete
    self.run_forever()
    ~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/asyncio/base_events.py", line 683, in run_forever
    self._run_once()
    ~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/asyncio/base_events.py", line 2042, in _run_once
    handle._run()
    ~~~~~~~~~~~^^
  File "/usr/lib/python3.13/asyncio/events.py", line 89, in _run
    self._context.run(self._callback, *self._args)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/broonie/git/b4/.venv/lib/python3.13/site-packages/textual/worker.py", line 370, in _run
    self._result = await self.run()
                   ^^^^^^^^^^^^^^^^
  File "/home/broonie/git/b4/.venv/lib/python3.13/site-packages/textual/worker.py", line 354, in run
    return await (
           ^^^^^^^
        self._run_threaded() if self._thread_worker else self._run_async()
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/broonie/git/b4/.venv/lib/python3.13/site-packages/textual/worker.py", line 326, in _run_threaded
    return await loop.run_in_executor(None, runner, self._work)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/concurrent/futures/thread.py", line 59, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/broonie/git/b4/.venv/lib/python3.13/site-packages/textual/worker.py", line 309, in run_callable
    return work()
  File "/home/broonie/git/b4/src/b4/review_tui/_tracking_app.py", line 1752, in _fetch_and_prepare
    am_msgs = lser.get_am_ready(
        noaddtrailers=True,
    ...<5 lines>...
        showchecks=False,
    )
  File "/home/broonie/git/b4/src/b4/__init__.py", line 1179, in get_am_ready
    msg = lmsg.get_am_message(
        add_trailers=add_trailers,
    ...<3 lines>...
        allowbadchars=allowbadchars,
    )
  File "/home/broonie/git/b4/src/b4/__init__.py", line 3306, in get_am_message
    sys.exit(1)
    ~~~~~~~~^^^
SystemExit: 1

Thanks,
Mark
signature.asc (application/pgp-signature, 488 B)