Re: [patch V5 00/14] MDS basics 0

Thomas Gleixner <[email protected]>
Newsgroups org.kernel.lore.historical-speck
Message-ID <[email protected]>
On Wed, 27 Feb 2019, speck for Linus Torvalds wrote:
> That looks better to me.
> 
> If I had my choice, I'd get rid of the "FAM6" thing entirely from the
> intel enumerations, but that's an independent thing

Is on that ever growing todo list thingy already.

> Although when I look at this, we actually already have a helper macro
> for the Intel case, and you could do
> 
>     INTEL_CPU_FAM6(ATOM_SALTWELL, NO_SPECULATION),
>     INTEL_CPU_FAM6(ATOM_SALTWELL_TABLET,   NO_SPECULATION),
>     ...
> 
> using the existing INTEL_CPU_FAM6() helper macro.
> 
> It's clearly not the first case people looked at those nasty model
> definitions and went "ugh. that's illegible".

Yes, but then I end up with two different macros in that table, which
is not helping readability either.

Thanks,

	tglx
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.