[MODERATED] Re: [PATCH v1 4/9] PERFv1 2

On Mon, Feb 04, 2019 at 05:14:05PM -0800, speck for Andi Kleen wrote:
> +static bool __use_counter3(struct perf_event *event)
> +{
> +	return event->hw.flags & PERF_X86_EVENT_ABORT_TSX;
> +}
> +
> +static bool use_counter3(struct perf_event *event)
> +{
> +	return __use_counter3(event) ||
> +		(event->group_leader && __use_counter3(event->group_leader));
> +}

See; I _really_ hate this per-event noodling.

Why not just have the sysctl tell us if PMC3 is available or not and set
FRA when PMC3 gets selected, teh end.