Re: [patch V6 04/14] MDS basics 4
Thomas Gleixner <[email protected]>
| Newsgroups | org.kernel.lore.historical-speck |
|---|---|
| Message-ID | <[email protected]> |
On Sat, 2 Mar 2019, speck for Frederic Weisbecker wrote: > On Fri, Mar 01, 2019 at 10:47:42PM +0100, speck for Thomas Gleixner wrote: > > if (cpu_matches(NO_MELTDOWN)) > > return; > > > > It looks weird to have it as a separate bug flag and not as a subset of full > MDS such as: > > #define NO_IDLE_SHARED_MDS BIT(4) > #define NO_SHARED_MDS BIT(5) > #define NO_MDS (NO_IDLE_SHARED_MDS | NO_SHARED_MDS) > > Now that would probably make sense only if the mitigation of full MDS required > to also imply a VERW before entering idle (that's the mitigation of MSBDS_ONLY, right?). > Turning off SMT removes the need to do that so the layout seem to make sense as is. Yeah, I had several variants of the theme, but all of them sucked in one way or the other. Thanks, tglx