[MODERATED] Re: [PATCH v5 02/11] TAAv5 2
Pawan Gupta <[email protected]>
| Newsgroups | org.kernel.lore.historical-speck |
|---|---|
| Message-ID | <[email protected]> |
> > +static void __init cpu_set_bug_bits(struct cpuinfo_x86 *c) > ^^^^^^ > > Please audit your newly added functions whether they can be __init > too. Newly added tsx functions are called after boot as well, either from sysfs or from the cpu hotplug path. I will see if some of them (mostly tsx_init()) can be changed to be __init. One likely call site for tsx_init() is identify_boot_cpu(), and then only do tsx_enable()/disable() from init_intel(). Thanks, Pawan