[MODERATED] Re: [PATCH v7 04/10] TAAv7 4
Borislav Petkov <[email protected]>
| Newsgroups | org.kernel.lore.historical-speck |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Oct 22, 2019 at 06:33:21PM -0700, speck for Pawan Gupta wrote:
> Is it okay to move x86_read_arch_cap_msr() further down just before its needed?
Yap, that's even better as it is common kernel code pattern: you
read/produce a value and then you do checks on it.
> + ia32_cap = x86_read_arch_cap_msr();
> +
you don't need this newline.
> if ((ia32_cap & ARCH_CAP_MDS_NO) &&
> !(ia32_cap & ARCH_CAP_TSX_CTRL_MSR))
> taa_mitigation = TAA_MITIGATION_UCODE_NEEDED;
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
--