[MODERATED] Re: [PATCH v7 03/10] TAAv7 3
Borislav Petkov <[email protected]>
| Newsgroups | org.kernel.lore.historical-speck |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Oct 21, 2019 at 01:25:02PM -0700, speck for Pawan Gupta wrote:
> +void __init tsx_init(void)
> +{
> + char arg[20];
Why 20? Magic?
Why not simply 4? We have "on" and "off" + '\0' AFAICT, no?
Also, you better clear that stack buffer:
char arg[4] = {};
before use.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
--