[MODERATED] Re: Re: [PATCH v7 03/10] TAAv7 3

On Tue, Oct 22, 2019 at 10:00:46AM -0700, speck for Pawan Gupta wrote:
> Again this is as per the feedback to create a new file for TSX as it is
> a feature. TAA stuff stays in bugs.c.

Well, with patchsets like that, it is always good to write a more
detailed changelog so that questions like that are answered from it.

Your 0/x message has

"- Refactor TSX code into new tsx.c"

but it would be a lot more helpful if it had the "why" you did it:

" - Carve out the TSX disabling functionality into a separate
compilation unit because it is a CPU feature."

This sentence could be a part of the patch commit message even.

This patchset has been going back'n'forth since May so people like me
forgetting things is kinda normal.

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
--