[MODERATED] Re: [PATCH 0/2] more sampling fun 0

Greg KH <[email protected]> Thu, 20 Feb 2020 16:05:49 +0100
Newsgroups org.kernel.lore.historical-speck
Message-ID <[email protected]>
On Thu, Feb 20, 2020 at 06:55:10AM -0800, speck for Andi Kleen wrote:
> > Then we need to stop using RDRAND internally for our "give me a random
> > number api" which has spread to more and more parts of the kernel.
> 
> Only if that API is called frequently enough. AFAIK it is not. 

It's called by all sorts of places in the kernel today.

> Normally it's used for rare rekeying of hash tables etc., which
> doesn't happen very often.

"normally" :)

> > Here's a patch that does so:
> > 	https://lore.kernel.org/lkml/[email protected]/
> > which I'm going to advise get merged now and backported to the stable
> > branches.
> 
> Don't see any reason at this point. Only do it if there's an actual
> indication of a problem.

It's slow, why wouldn't we stop using it as we already have a much
faster call.

thanks,

greg k-h