[MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1

On Thu, Feb 06, 2020 at 02:11:02PM -0800, speck for mark gross wrote:
> From: mark gross <[email protected]>
> Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in the
>  vulnerability white list structure.
> 
> From: mark gross <[email protected]>
> Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in the

That second subject is incomplete. Do just one pls.

Also, you need a subject prefix:

x86/CPU: Add ...

git log arch/x86/

is your friend if you're wondering what to call it.

> Intel has produced processors with the same CPUID family+model. Code
> may need to check the stepping when programming model specific behavior.
> 
> Add an API to allow easy specification of stepping or range of steppings
> with a 16 bit bitmask.
> 
> Update cpu_vuln_whitelist using this new API.
> 
> I implemented this in the way I did to avoid modifying x86_cpu_id as
> that structure is an exported ABI and any change would impact user mode
> code using the structure.

Exported ABI? Which usermode code uses this? The module loading tools?

Even if, we do add new struct members at the end of exported structs
just fine. So what is the problem here?

> Signed-off-by: mark gross <[email protected]>
> Reviewed-by: tony luck <[email protected]>

Please write names capitalized.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
--