[MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1

On Wed, Feb 26, 2020 at 12:07:37PM +0100, speck for Borislav Petkov wrote:
> On Thu, Feb 06, 2020 at 02:11:02PM -0800, speck for mark gross wrote:
> > From: mark gross <[email protected]>
> > Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in the
> >  vulnerability white list structure.
> > 
> > From: mark gross <[email protected]>
> > Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in the
> 
> That second subject is incomplete. Do just one pls.
Ok  FWIW the instructions for using the speckify-gitmail said something about
copying the subject and from lines into the body.

> Also, you need a subject prefix:
> 
> x86/CPU: Add ...
ok

> 
> git log arch/x86/
> 
> is your friend if you're wondering what to call it.
Thanks!

> > Intel has produced processors with the same CPUID family+model. Code
> > may need to check the stepping when programming model specific behavior.
> > 
> > Add an API to allow easy specification of stepping or range of steppings
> > with a 16 bit bitmask.
> > 
> > Update cpu_vuln_whitelist using this new API.
> > 
> > I implemented this in the way I did to avoid modifying x86_cpu_id as
> > that structure is an exported ABI and any change would impact user mode
> > code using the structure.
> 
> Exported ABI? Which usermode code uses this? The module loading tools?

Yeah, Andi pointed it out to me on an internal review.  I don't know what tool
is using it.

> 
> Even if, we do add new struct members at the end of exported structs
> just fine. So what is the problem here?
FWIW doing it this way made a cleaner patch without touching a dozen other
files using that structure.  I'd rather stay with the way it is but, if you
feel strongly I can do a version of what I had before only adding the new
members to the end.  Please let me know.


> > Signed-off-by: mark gross <[email protected]>
> > Reviewed-by: tony luck <[email protected]>
> 
> Please write names capitalized.
Ok.

Thanks!

--mark

> -- 
> Regards/Gruss,
>     Boris.
> 
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
> --