[MODERATED] Re: [PATCH] Raffle 0
Greg KH <[email protected]> Tue, 14 Jul 2020 07:57:35 +0200
| Newsgroups | org.kernel.lore.historical-speck |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jul 13, 2020 at 05:03:44PM -0700, speck for Pawan Gupta wrote: > From: Pawan Gupta <[email protected]> > Subject: [PATCH] powercap: restrict energy meter to root access > > From: Len Brown <[email protected]> > > Remove non-privileged user access to power data contained in > /sys/class/powercap/intel_rapl/*/energy_uj > > Non-privileged users currently have read access to power data and can > use this data to form a security attack. Some privileged > drivers/applications need read access to this data but don't expose it > to non-privileged users. > > For example, thermald uses this data to ensure that power management > works correctly. Thus removing non-privileged access is preferred over > completely disabling this power reporting capability with > CONFIG_INTEL_RAPL=n. > > Fixes: 95677a9a3847 ("PowerCap: Fix mode for energy counter") > Signed-off-by: Len Brown <[email protected]> So you forwarded on a patch from someone else but did not put your own signed-off-by on it? That's not good :( Also, why is this being sent to speck? What is wrong with the normal development process? thanks, greg k-h