Re: update firmware binary for v5.4

On Wed, Nov 19, 2025 at 07:57:30PM +0530, Vikash Garodia wrote:
> Hello Dmitry,
> 
> On 11/19/2025 4:55 PM, Dmitry Baryshkov wrote:
> > On Wed, Nov 19, 2025 at 05:39:43PM +0800, Renjiang Han wrote:
> > > Hi
> > > 
> > > The following changes since commit 6fc940781a013ad837ed8fea326d2b897467bbc3:
> > > 
> > >    Merge branch 'robot/patch-0-1762826844' into 'main' (2025-11-11 12:02:02
> > > +0000)
> > > 
> > > are available in the Git repository at:
> > > 
> > >    https://git.codelinaro.org/clo/linux-kernel/linux-firmware.git
> > > update-video-fw-sm6150
> > > 
> > > for you to fetch changes up to 0a6f987b7b07a6fec2d4fd42ac4473c0523d3af6:
> > > 
> > >    qcom: venus-5.4: update firmware binary for v5.4 (2025-11-19 15:04:09
> > > +0530)
> > > 
> > > ----------------------------------------------------------------
> > > Renjiang Han (1):
> > >        qcom: venus-5.4: update firmware binary for v5.4
> > > 
> > >   WHENCE                      |   6 +-----
> > >   qcom/venus-5.4/venus.mbn    | Bin 922216 -> 922312 bytes
> > 
> > And this firmware file is also going to work on SC7180, correct?
> 
> Yes, we have got this validated on SC7180 as well.

Thanks for the confirmation.

> 
> > 
> > >   qcom/venus-5.4/venus_s2.mbn | Bin 919008 -> 0 bytes
> > 
> > Vikash, Dikshita, could you please comment, what is going on here?
> > 
> > We have added venus_s6.mbn, then dropped it, saying that a normal
> > venus.mbn can be used on QCS615. Then Renjiang added venus_s2.mbn
> > (why?). Mario merged it despite my NAK, but that's a separate topic.
> > Now we are dropping it again.
> > 
> > The firmware is the ABI between userspace and the kernel. We can't
> > randomly add and remove files here.
> > 
> > Which file names are / were in use by the upstream kernel? I tried hard,
> > but I couldn't find any mention of venus_s2.mbn in any of the patches
> > on the linux-arm-msm mailing list.
> 
> venus_s2.mbn is not used anywhere. It was earlier planned to be used on

Ack, please split into two commits, each having a proper explanation.
Please make sure that in future we don't add completely unused files.

> qcs615 while venus.mbn would continue on sc7280, but then we wanted to use
> same bins for sc7180 and qcs615.

What is the status of the current venus-5.4/venus.mbn file? Does it work
AS IS on Talos EVK that is being in process of upstreaming and on QCS615
ADP AIR aka RIDE boards?

> S2 variant can be produced now by re-signing this venus.mbn itself. To
> achieve this part, there were some elf alignment fixes, which is done with
> this bin to make it re-signable with any vendor specific #.

I thought that this already happened for VIDEO.VE.5.4-00060-PROD-1. What
is the difference between it and the new one?

-- 
With best wishes
Dmitry