Re: [PATCH] mediatek: add symlink for MT8188 SCP dual core firmware

On Tue, 2026-01-13 at 08:17 +0200, Dmitry Baryshkov wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Tue, Jan 13, 2026 at 01:15:21PM +0800, Chen-Yu Tsai wrote:
> > On Tue, Jan 13, 2026 at 10:10 AM Moudy Ho <[email protected]>
> > wrote:
> > > 
> > > The MT8188 device tree (DTS) is configured for dual core SCP, and
> > > the
> > > driver by default attempts to load "scp_c0.img" as the core 0
> > > firmware.
> > > Without this symlink, the firmware fails to load and the
> > > following error
> > > is observed:
> > > 
> > >   [   79.494105] remoteproc remoteproc0: powering up scp
> > >   [   79.496217] remoteproc remoteproc0: Booting fw image
> > > mediatek/mt8188/scp.img, size 636548
> > >   [   79.497298] platform 10500000.scp: IPI buf addr 0x000ffb40
> > >   [   79.498013] platform 10500000.scp: IPI buffer does not fit
> > > in SRAM.
> > > 
> > > This patch adds a symlink "scp_c0.img" pointing to "scp.img"
> > > under
> > > meditek/mt8188/ to ensure proper firmware loading for dual core
> > > SCP.
> > 
> > It should be the opposite. "scp_c0.img" is the proper name used
> > upstream,
> > "scp.img" is the old name used in old DTBs.
> > 
> > So you should rename "scp.img" to "scp_c0.img", and then add a
> > symlink
> > "scp.img" pointing to "scp_c0.img".
> 
> ALso please use the Link: string inside WHENCE file instead of
> actually
> creating a symlink.
> 

Hi Chen-Yu & Dmitry,

Thanks for your suggestions! I'll make the necessary changes in the
next version.

Thanks & Regards,
Moudy

> > 
> > > Signed-off-by: Moudy Ho <[email protected]>
> > > ---
> > >  mediatek/mt8188/scp_c0.img | 1 +
> > >  1 file changed, 1 insertion(+)
> > >  create mode 120000 mediatek/mt8188/scp_c0.img
> > > 
> > > diff --git a/mediatek/mt8188/scp_c0.img
> > > b/mediatek/mt8188/scp_c0.img
> > > new file mode 120000
> > > index 00000000..8d1dcd4d
> > > --- /dev/null
> > > +++ b/mediatek/mt8188/scp_c0.img
> > > @@ -0,0 +1 @@
> > > +scp.img
> > > \ No newline at end of file
> > > --
> > > 2.45.2
> > > 
> > > 
> 
> --
> With best wishes
> Dmitry