Re: qcom: add ADSP, CDSP notice files for sm8750 platform

On Thu, Mar 05, 2026 at 02:50:08PM +0530, Venkata Kota wrote:
> 
> 
> On 3/5/2026 2:44 PM, Dmitry Baryshkov wrote:
> > On Thu, Mar 05, 2026 at 11:48:16AM +0530, Saddam Patan wrote:
> > > The following changes since commit f69a5e73c0c0c927a5bea53ce707ef17afae1964:
> > > 
> > >    Merge branch 'audioreach-tplg' into 'main' (2026-03-03 19:46:20 +0000)
> > > 
> > > are available in the Git repository at:
> > > 
> > >    https://git.codelinaro.org/clo/linux-kernel/linux-firmware.git
> > > dsp-fw-pakalanotice
> > > 
> > > for you to fetch changes up to aa05d14567ea5de6790a4ae199b4ab2ab1025fb4:
> > > 
> > >    qcom: add ADSP, CDSP notice files for sm8750 platform (2026-03-05 11:46:08
> > > +0530)
> > > 
> > > ----------------------------------------------------------------
> > > Saddam Patan (1):
> > >        qcom: add ADSP, CDSP notice files for sm8750 platform
> > 
> > It's impossible to comment such a pull request, so could you please
> > send this next time as a patch rather than a pull request?
> > 
> > Also please check the comments that I've left for the DSP binaries PR,
> > and apply the relevant ones.
> > 
> > > 
> > >   WHENCE                      |    2 +
> > >   qcom/sm8750/Notice_adsp.txt | 3214 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >   qcom/sm8750/Notice_cdsp.txt | 1270 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 
> > Are you saying that DSP binaries and DSP firmware have exactly the same
> > set of 3rd party software in them? That's very, very suspicious.
> <Noted> The Notice file is generated for the entire CRM in one shot. These
> are not generated separately in the build for binaries and firmware.There
> are typically dependencies between the firmware and the binaries and in a
> way some of them need to go together and the overlap of dependencies on the
> 3rd party software is very much a possibility.

And I've kept on saying that the notice file should be covering only
those binaries, with which the notice is being provided. Don't provide
irrelevant data, especially in the legal field.

> > 
> > >   3 files changed, 4486 insertions(+)
> > >   create mode 100644 qcom/sm8750/Notice_adsp.txt
> > >   create mode 100644 qcom/sm8750/Notice_cdsp.txt
> > 
> 

-- 
With best wishes
Dmitry