Re: [External] Re: [PATCH] WHENCE: Fix ISH firmware symlink prefix for Lenovo PTL systems

Thank you for the review.

Merged and pushed out.

https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/993

josh

On Wed, Apr 8, 2026 at 8:27 AM Vishnu Sankar <[email protected]> wrote:
>
> Hi Josh,
>
> Thanks for sharing the patch.
>
> After reviewing this, we realized that the incorrect symlink name was introduced from our side. Sorry for this.
> This fix correctly help the firmware to be loaded on PTL systems.
>
> We ACK this patch. Please go ahead and accept it.
>
> Thanks @Aaron Ma
>
> ________________________________________
> Vishnu Sankar
> Staff Engineer, SW
> Minatomirai Center Bldg, 21F
> 3-6-1 Minatomirai, Nishi-ku, Yokohama, Kanagawa
> 220-0012 JAPAN
>
> Solutions Development
> Lenovo Japan
>
>  [email protected]
>
> Lenovo.com
> Facebook | Instagram | LinkedIn | TikTok | X | YouTube | Privacy
>
>
> ________________________________________
> From: Josh Boyer <[email protected]>
> Sent: 08 April 2026 20:53
> To: Aaron Ma <[email protected]>; Richie roy Jayme2 <[email protected]>; Vishnu Sankar <[email protected]>; [email protected] <[email protected]>; Vishnu Sankar <[email protected]>
> Cc: [email protected] <[email protected]>
> Subject: [External] Re: [PATCH] WHENCE: Fix ISH firmware symlink prefix for Lenovo PTL systems
>
> Vishnu/Richie, can you review this patch?
>
> josh
>
> On Wed, Apr 8, 2026 at 4:28 AM Aaron Ma <[email protected]> wrote:
> >
> > Tested on ThinkPad X1 2-in-1 Gen 11 (21V9SIT260) with kernel 7.0-rc6:
> > renaming the symlink to ish_ptl_53c4ffad_bc3e29f7.bin loads the firmware
> > successfully (v5.8.1.7782) and all three HID sensor hubs enumerate.
> >
> > Fixes: 87a7d3c72b19 ("Add LENOVO ISH firmware v5.8.1.7720 for X1 Carbon (Gen 14) and X1 2-in-1 (Gen 11)")
> > Signed-off-by: Aaron Ma <[email protected]>
> > ---
> >  WHENCE | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/WHENCE b/WHENCE
> > index b243fee39..c46dc429b 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -9928,9 +9928,9 @@ Info: product_family - "ThinkPad X9-15 Gen 1"
> >  Version: 5.8.0.7720
> >
> >  File: LENOVO/ish/ish_ptl_lenovo_X1_2026_5.8.1.7782.bin
> > -Link: intel/ish/ish_lnlm_53c4ffad_bc3e29f7.bin -> ../../LENOVO/ish/ish_ptl_lenovo_X1_2026_5.8.1.7782.bin
> > +Link: intel/ish/ish_ptl_53c4ffad_bc3e29f7.bin -> ../../LENOVO/ish/ish_ptl_lenovo_X1_2026_5.8.1.7782.bin
> >  Info: product_family - "ThinkPad X1 2-in-1 Gen 11"
> > -Link: intel/ish/ish_lnlm_53c4ffad_75d6ebe2.bin -> ../../LENOVO/ish/ish_ptl_lenovo_X1_2026_5.8.1.7782.bin
> > +Link: intel/ish/ish_ptl_53c4ffad_75d6ebe2.bin -> ../../LENOVO/ish/ish_ptl_lenovo_X1_2026_5.8.1.7782.bin
> >  Info: product_family - "ThinkPad X1 Carbon Gen 14"
> >  Version: 5.8.1.7782
> >
> > --
> > 2.43.0
> >