RE: [PATCH] rtw88: add firmware v41.0.0 for RTL8723B

[email protected] <[email protected]> wrote:
> From: Luka Gejak <[email protected]>
>=20
> Add the RTL8723B NIC firmware image used by the rtw88 driver. Support for
> the RTL8723BS (SDIO) device that uses it is being added to the mainline
> rtw88 driver.
>=20
> The image was extracted from the Realtek "rtl8723bs" vendor driver,
> version v5.2.17.1_26955.20180307_COEX20180201-6f52, from the C array
> array_mp_8723b_fw_nic[] in hal/rtl8723b/hal8723b_fw.c, using the
> convert_firmware.c tool. A public copy of that vendor driver is at
> https://github.com/MocLG/rtl8723bs-5.2.17
>=20
> The image reports version 41.0.0 and is covered by the existing Realtek
> redistribution licence (LICENCE.rtlwifi_firmware.txt).
>=20
> Signed-off-by: Luka Gejak <[email protected]>

I checked firmware binary with official release. They are identical.=20

Except to a nit below,

Reviewed-by: Ping-Ke Shih <[email protected]>

> ---
>  WHENCE                |   1 +
>  rtw88/rtw8723b_fw.bin | Bin 0 -> 32272 bytes
>  2 files changed, 1 insertion(+)
>  create mode 100644 rtw88/rtw8723b_fw.bin
>=20
> diff --git a/WHENCE b/WHENCE
> index 6cfe142d4e91..b4b7e6acda1c 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -3352,6 +3352,7 @@ File: rtw88/rtw8822c_fw.bin
>  File: rtw88/rtw8822c_wow_fw.bin
>  File: rtw88/README

Why not putting rtw8723b_fw.bin here in alphabetic order?

>  File: rtw88/rtw8723d_fw.bin
> +File: rtw88/rtw8723b_fw.bin
>  File: rtw88/rtw8821c_fw.bin
>  File: rtw88/rtw8703b_fw.bin
>  File: rtw88/rtw8703b_wow_fw.bin