[PATCH 4/5] Make instructions for automatic signing more reliable
Konstantin Ryabitsev <[email protected]> Thu, 3 Jun 2021 13:18:14 -0400
| Newsgroups | org.kernel.lore.signatures |
|---|---|
| Message-ID | <1fc7ed529fc07036072b79c040f083b1db1c668a.1622740672.git.konstantin.ryabitsev@linux.dev> |
From: Paul Barker <[email protected]> We can't assume that the git directory path is '.git' from the root of the source tree. For example, this is not the correct path if patatt is checked out as a git submodule. We should use `git rev-parse --git-dir` to reliably determine the git directory path. We should also surround the path in quotes in case the user has cloned patatt in a path containing spaces. Signed-off-by: Paul Barker <[email protected]> Signed-off-by: Konstantin Ryabitsev <[email protected]> Link: https://lore.kernel.org/r/[email protected] --- README.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.rst b/README.rst index b751b68..de299d1 100644 --- a/README.rst +++ b/README.rst @@ -184,8 +184,8 @@ Automatic signing via the sendemail-validate hook If everything is working well, you can start automatically signing all outgoing patches sent via git-send-email:: - $ echo 'patatt sign --hook "${1}"' > .git/hooks/sendemail-validate - $ chmod a+x .git/hooks/sendemail-validate + $ echo 'patatt sign --hook "${1}"' > "$(git rev-parse --git-dir)/hooks/sendemail-validate" + $ chmod a+x "$(git rev-parse --git-dir)/hooks/sendemail-validate" PGP vs ed25519 keys considerations ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- 2.31.1