Re: [PATCH/RFC 10/14] dt-bindings: power: Document Renesas R-Car X5H Module Controller

On 5/8/26 9:47 AM, Geert Uytterhoeven wrote:

Hello Geert,

> On Thu, 7 May 2026 at 23:53, Marek Vasut <[email protected]> wrote:
>> On 4/21/26 8:11 PM, Geert Uytterhoeven wrote:
>>> +  '#power-domain-cells':
>>> +    description: |
>>> +      - The first power domain specifier cell must be either the Module
>>> +        Power Domain Gating (MPDG) register index (0x00-0x3f) from the
>>> +        datasheet, or a Power Domain number, as defined in
>>> +        <dt-bindings/power/renesas,r8a78000-mdlc.h>,
>>> +      - The second power domain specifier cell must be the module number
>>> +        (0x00-0xff), composed of the Module System Reset (MSRES) register index
>>> +        in the high nibble, and the Module Reset Destination bitfield index in
>>> +        the low nibble.
>>> +    const: 2
>>> +
>>> +  '#reset-cells':
>>> +    description:
>>> +      The single reset specifier cell must be the module number (0x00-0xff).
>>> +    const: 1
>> Just one more question -- the power-domain-cells second cell and
>> reset-cells are always going to be identical values, correct ? If so, it
> 
> Yes they are.
> 
>> would be nice to keep the description: aligned, and maybe even indicate
>> in the description that those two values have to be the same.
> 
> I thought that was obvious (but apparently it is not)? The descriptions
> are identical, except for the latter not explaining again what a module
> number is composed of...

Please do spell it out in the document, this is a complicated topic and 
every little bit of extra clarity helps.

Thank you !
-- 
Best regards,
Marek Vasut