Re: [PATCH 0/5] scmi: Log client subsystem entity counts
Sudeep Holla <[email protected]>
| Newsgroups | org.kernel.vger.arm-scmi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <20260514-finicky-acoustic-flounder-2dd405@sudeepholla> |
On Thu, May 14, 2026 at 08:48:19AM +0200, Greg Kroah-Hartman wrote: > On Wed, May 13, 2026 at 11:27:21AM -0700, Guenter Roeck wrote: > > On 5/13/26 11:02, Andy Shevchenko wrote: > > > +Greg (I believe the trend is to drop such messages and not add them [back]?) > > > > > > > Is there some common guidance on this ? I'd be all for dropping messages > > instead of adding them, but there seems to be a perpetual battle between > > people who want to log everything and people concerned about logging noise. > > As maintainer I always seem to be stuck between those two camps. > > When drivers work properly, they should be quiet. This patch series > adds a bunch of dev_info() calls, which is not ok. If a developer wants > to see extra messages, use the dev_dbg() infrastructure, or the tracing > infrastructure, both of which are there for this very reason. > I completely agree and tend to follow that. But I always assumed it was left to maintainers taste. > So yes, I agree with Andy, this series is not ok, don't make more noise > please. > I am now thinking if [1] was the one setting example for this series. I did ack it as I left it to the subsystem maintainer's choice(in this case author as well). -- Regards, Sudeep [1] https://lore.kernel.org/all/[email protected]/