[PATCH v8 01/13] powercap: Add enable disable control-type
Philip Radford <[email protected]> Wed, 1 Jul 2026 12:57:35 +0000
| Newsgroups | org.kernel.vger.arm-scmi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
Add functionality to disable or enable the Powercap control-type by writing directly into sys/class/powercap/arm-scmi/enabled. Signed-off-by: Philip Radford <[email protected]> --- drivers/powercap/arm_scmi_powercap.c | 155 ++++++++++++++++++++++++++- 1 file changed, 154 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/arm_scmi_powercap.c b/drivers/powercap/arm_scmi_powercap.c index ab66e9a3b1e2..e33829d5c551 100644 --- a/drivers/powercap/arm_scmi_powercap.c +++ b/drivers/powercap/arm_scmi_powercap.c @@ -33,13 +33,151 @@ struct scmi_powercap_zone { struct scmi_powercap_root { unsigned int num_zones; + bool enabled; + struct list_head node; struct scmi_powercap_zone *spzones; struct list_head *registered_zones; struct list_head scmi_zones; }; +static LIST_HEAD(scmi_powercap_roots); +static DEFINE_MUTEX(scmi_powercap_roots_lock); + static struct powercap_control_type *scmi_top_pcntrl; +static bool scmi_powercap_is_control_type_child(const struct scmi_powercap_zone *spz) +{ + return spz->registered && !spz->invalid && + spz->info->parent_id == SCMI_POWERCAP_ROOT_ZONE_ID; +} + +static int +scmi_powercap_read_root_children_enable_state(struct scmi_powercap_root *pr, bool *mode) +{ + struct scmi_powercap_zone *spz; + bool enabled; + int i, ret; + + *mode = true; + + for (i = 0; i < pr->num_zones; i++) { + spz = &pr->spzones[i]; + + if (!scmi_powercap_is_control_type_child(spz)) + continue; + + ret = powercap_ops->cap_enable_get(spz->ph, spz->info->id, &enabled); + if (ret) + return ret; + + if (!enabled) { + *mode = false; + return 0; + } + } + + return 0; +} + +static int +scmi_powercap_set_root_children_enable_state(struct scmi_powercap_root *pr, bool enable) +{ + struct scmi_powercap_zone *spz; + bool *prev_state; + int i, ret; + + prev_state = kcalloc(pr->num_zones, sizeof(*prev_state), GFP_KERNEL); + if (!prev_state) + return -ENOMEM; + + for (i = 0; i < pr->num_zones; i++) { + spz = &pr->spzones[i]; + + if (!scmi_powercap_is_control_type_child(spz)) + continue; + + ret = powercap_ops->cap_enable_get(spz->ph, spz->info->id, + &prev_state[i]); + + if (ret) + goto revert; + + if (prev_state[i] == enable) + continue; + + ret = powercap_ops->cap_enable_set(spz->ph, spz->info->id, enable); + if (ret) + goto revert; + } + + pr->enabled = enable; + kfree(prev_state); + return 0; + +revert: + while (--i >= 0) { + spz = &pr->spzones[i]; + + if (!scmi_powercap_is_control_type_child(spz)) + continue; + if (!spz->info->powercap_cap_config) + continue; + if (prev_state[i] == enable) + continue; + + powercap_ops->cap_enable_set(spz->ph, spz->info->id, prev_state[i]); + } + + kfree(prev_state); + return ret; +} + +static int +scmi_powercap_control_type_set_enable(struct powercap_control_type *pct, bool mode) +{ + struct scmi_powercap_root *pr; + int ret = 0; + + mutex_lock(&scmi_powercap_roots_lock); + list_for_each_entry(pr, &scmi_powercap_roots, node) { + ret = scmi_powercap_set_root_children_enable_state(pr, mode); + if (ret) + break; + } + mutex_unlock(&scmi_powercap_roots_lock); + + return ret; +} + +static int +scmi_powercap_control_type_get_enable(struct powercap_control_type *pct, bool *mode) +{ + struct scmi_powercap_root *pr; + int ret = 0; + + *mode = true; + + mutex_lock(&scmi_powercap_roots_lock); + list_for_each_entry(pr, &scmi_powercap_roots, node) { + ret = scmi_powercap_read_root_children_enable_state(pr, &pr->enabled); + + if (ret) + break; + if (!pr->enabled) { + *mode = false; + break; + } + } + mutex_unlock(&scmi_powercap_roots_lock); + + return ret; +} + +static const struct powercap_control_type_ops scmi_powercap_control_type_ops = { + .set_enable = scmi_powercap_control_type_set_enable, + .get_enable = scmi_powercap_control_type_get_enable, +}; + static int scmi_powercap_zone_release(struct powercap_zone *pz) { return 0; @@ -495,6 +633,16 @@ static int scmi_powercap_probe(struct scmi_device *sdev) if (ret) return ret; + INIT_LIST_HEAD(&pr->node); + + ret = scmi_powercap_read_root_children_enable_state(pr, &pr->enabled); + if (ret) + return ret; + + mutex_lock(&scmi_powercap_roots_lock); + list_add_tail(&pr->node, &scmi_powercap_roots); + mutex_unlock(&scmi_powercap_roots_lock); + dev_set_drvdata(dev, pr); return ret; @@ -505,6 +653,10 @@ static void scmi_powercap_remove(struct scmi_device *sdev) struct device *dev = &sdev->dev; struct scmi_powercap_root *pr = dev_get_drvdata(dev); + mutex_lock(&scmi_powercap_roots_lock); + list_del(&pr->node); + mutex_unlock(&scmi_powercap_roots_lock); + scmi_powercap_unregister_all_zones(pr); } @@ -525,7 +677,8 @@ static int __init scmi_powercap_init(void) { int ret; - scmi_top_pcntrl = powercap_register_control_type(NULL, "arm-scmi", NULL); + scmi_top_pcntrl = powercap_register_control_type(NULL, "arm-scmi", + &scmi_powercap_control_type_ops); if (IS_ERR(scmi_top_pcntrl)) return PTR_ERR(scmi_top_pcntrl); -- 2.25.1