Re: [PATCH v2 05/10] dt-bindings: clock: renesas,r8a78000-cpg: Add firmware property
Rob Herring <[email protected]> Thu, 16 Jul 2026 16:49:24 -0500
| Newsgroups | org.kernel.vger.arm-scmi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Jul 10, 2026 at 01:02:39PM +0200, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Fri, 10 Jul 2026 at 12:21, Krzysztof Kozlowski <[email protected]> wrote: > > On Wed, Jul 08, 2026 at 12:16:23PM +0200, Geert Uytterhoeven wrote: > > > Add a firmware property, for systems where SCMI must be used instead of > > > direct hardware access. > > > > > > Signed-off-by: Geert Uytterhoeven <[email protected]> > > > --- > > > v2: > > > - Spin off from "dt-bindings: clock: Document Renesas R-Car X5H Clock > > > Pulse Generator". > > > --- > > > .../devicetree/bindings/clock/renesas,r8a78000-cpg.yaml | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml b/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml > > > index 4e23bba334382346..fc499e7cf52e4f0c 100644 > > > --- a/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml > > > +++ b/Documentation/devicetree/bindings/clock/renesas,r8a78000-cpg.yaml > > > @@ -35,6 +35,12 @@ properties: > > > <dt-bindings/clock/renesas,r8a78000-cpg.h>. > > > const: 1 > > > > > > + firmware: > > > > RPi is doing similar, but I have doubts. It looks way too close to > > generic "syscon" which is disallowed. > > > > I think this should be vendor+purpose specific, e.g.: > > "renesas,scmi-transport" or "renesas,scmi-firmware" If you can tell me the resource that a 'firmware' provider provides then it is fine, but you can't. > The disadvantage of a vendor-specific property is that there are more > cases to handle for fw_devlink, cfr. "[PATCH v2 02/10] of: property: > fw_devlink: Add support for firmware"[1]. If vendor specific phandle properties are a problem for fw_devlink, then we already have that problem to solve and 1 more doesn't matter. Rob