Re: [PATCH v1 2/4] firmware: arm_scpi: reject DVFS OPP count above MAX_DVFS_OPPS
Sudeep Holla <[email protected]> Mon, 27 Jul 2026 20:49:59 +0100
| Newsgroups | org.kernel.vger.arm-scmi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260727-practical-chachalaca-of-perfection-7bcf42@sudeepholla> |
On Mon, Jul 27, 2026 at 10:19:15AM +0800, Xixin Liu wrote: > scpi_dvfs_get_info() already rejected a zero opp_count, but still trusted > any larger value from the SCP firmware. The shared-memory reply only holds > MAX_DVFS_OPPS entries in buf.opps[]; a bigger count over-reads that array > and then sizes the allocated OPP table incorrectly (garbage OPPs / OOB). > > Reject zero and out-of-range counts in one check and return -EINVAL. > This fails to apply, you need to rebase to the latest. -- Regards, Sudeep