Re: [PATCH v2] firmware: arm_scmi: pm: use DEFINE_SIMPLE_DEV_PM_OPS for pm struct
Uwe Kleine-König <[email protected]>
| Newsgroups | org.kernel.vger.arm-scmi,org.infradead.lists.linux-arm-kernel |
|---|---|
| Message-ID | <aoaLBNkkSynoGH5M@monoceros> |
On Thu, Aug 20, 2026 at 10:17:18AM +0800, Li Jun wrote: > use DEFINE_SIMPLE_DEV_PM_OPS for scmi_dev_pm_ops,and add the value of > .freeze .thaw .poweroff .restore.if these address are null, may cause > error in s4. > > Change: > -Replace SIMPLE_DEV_PM_OPS() in v1 with DEFINE_SIMPLE_DEV_PM_OPS() for pm. > > Signed-off-by: Li Jun <[email protected]> The things I wrote at https://lore.kernel.org/all/aoaFlNcXC8zfS0j5@monoceros/ mostly apply here, too. TL;DR: Wrong placement of inter-revision changelog, missing pm_sleep_ptr(), and maybe most prominently the request for patience to start with a single patch and learn from the feedback for later patches. Best regards Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqGjDoACgkQj4D7WH0S /k72yAf/Xemjdc635zCuZFUG//Sy+vXuZ9veArfR+8cm4wu1BmIGSXXCH80VU63b X/hJh3utR5VCmn7t5qP2jbKooon7mfghtKW1EyNvByfsbWhxZ2g+fPBKRfef8aCG BCscpFWVfEgjG8cEKBSJCY2+ufqAztavvGOfKWE7sNFomTP2cxySPUKm+eZ2Aoz+ TeR0+45yRxzKk5747ALvDo6N4XWeKpJPxNRE5/c8mI0ADF+5S5bqkQxOC5coAgok rLhBbkLGQ8ci2KCsrYv38BSn1yuIQg1W8M3k+G28pHb4OLrhU1pZ9TZ8EyDtiHjJ f3ltyL2zRkpIm7nqqOEYlD7501KxwQ== =rYU0 -----END PGP SIGNATURE-----