Re: [PATCH v10 11/24] firmware: arm_scmi: Add Telemetry notification support
Fayssal Benmlih <[email protected]>
| Newsgroups | org.kernel.vger.arm-scmi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Cristian,
The V10 multiplication and wire-payload boundary checks address the first
notification issue I reported in V7.
The decoded report sizing issue appears to remain.
tlm_events[] still declares:
.max_payld_sz = 0,
.max_report_sz = 0,
so the generic code allocates max_msg_size for the decoded report.
However, struct scmi_telemetry_update_report has a larger fixed header than
the wire payload because it also contains ktime_t.
A maximum-sized valid wire payload can therefore require more than
max_msg_size once decoded, even though the wire message itself passed the
transport-size check. The comment in fill_custom_report() that both objects
are max_msg_size does not account for this header-size difference.
Please either allocate a report large enough for the decoded header plus
the maximum dword array, or constrain num_dwords using the actual decoded
report-buffer capacity before copying.
Thanks,
Fayçal