Re: [RFC][PATCH 10/13] get rid of audit_reusename()
Al Viro <[email protected]>
| Newsgroups | org.kernel.vger.audit,org.kernel.vger.io-uring,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <20251110060554.GK2441659@ZenIV> |
On Sun, Nov 09, 2025 at 02:18:04PM -0800, Linus Torvalds wrote: > On Sun, 9 Nov 2025 at 11:18, Linus Torvalds > <[email protected]> wrote: > > > > Hmm? Comments? > > Oh, and while double-checking bad users, I note that ntfs3 does > > uni = kmem_cache_alloc(names_cachep, GFP_NOWAIT); > ... > kmem_cache_free(names_cachep, uni); > > which is all complete and utter bogosity. I have no idea why anybody > ever thought that was acceptable. It's garbage. So's ntfs_d_compare() right next to it - and there they *still* hadn't bothered with non-blocking allocation while under ->d_lock and rcu_read_lock()...