Re: [PATCH v5 1/2] audit: add audit_log_packet_ip4 and audit_log_packet_ip6 helper functions
Florian Westphal <[email protected]>
| Newsgroups | org.kernel.vger.audit,org.kernel.vger.linux-kernel,org.kernel.vger.netfilter-devel |
|---|---|
| Message-ID | <[email protected]> |
Ricardo Robaina <[email protected]> wrote: > > +int audit_log_nft_skb(struct audit_buffer *ab, > > + struct sk_buff *skb, u8 nfproto) > Thanks for reviewing this patch, Paul. > > It makes sense to me. I'll work on a newer version addressing your suggestions. Nit, but as you need to resend anyway, can you also make this 'const struct sk_buff *' ? Also, given this isn't nftables specific, I suggest audit_log_nf_skb, audit_log_netfilter_skb or some such instead. Thanks.