Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context setup and reset paths
Mateusz Guzik <[email protected]>
| Newsgroups | org.kernel.vger.audit,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAGudoHFz1QZdYTp=PbAF+v-3-EZhwL0PQz+Zv0nNTG0WCSAdAw@mail.gmail.com> |
On Thu, Feb 5, 2026 at 6:20 AM Al Viro <[email protected]> wrote: > Mateusz: *is* there a measurable effect? Because if there isn't, I'm > very tempted to simply revert that thing. "Churn of adding fs_struct.h > as needed" is not the problem - try "exposing the object internals to > far larger subset of the kernel". We had interesting bugs with weird > shit deciding to poke in there, locking and refcounting be damned. This one I did not bother benchmarking as it is an obvious change -- read a var directly instead of going through a func call. If this is causing trouble then it definitely needs to be reverted, but any woes only speak to the mess in the header files.