Re: [PATCH v2 2/2] tree-wide: rename do_exit() to task_exit()
Steven Rostedt <[email protected]> Tue, 10 Mar 2026 20:02:17 -0400
| Newsgroups | org.kernel.vger.audit,dev.linux.lists.netfs,dev.linux.lists.virtualization,org.kernel.vger.bpf,org.kernel.vger.io-uring,org.kernel.vger.kvm,org.kernel.vger.linux-doc,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.netdev,org.kernel.vger.rcu,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 10 Mar 2026 15:56:10 +0100 Christian Brauner <[email protected]> wrote: > diff --git a/tools/testing/selftests/bpf/progs/tracing_failure.c b/tools/testing/selftests/bpf/progs/tracing_failure.c > index 65e485c4468c..5144f4cc5787 100644 > --- a/tools/testing/selftests/bpf/progs/tracing_failure.c > +++ b/tools/testing/selftests/bpf/progs/tracing_failure.c > @@ -25,7 +25,7 @@ int BPF_PROG(tracing_deny) > return 0; > } > > -SEC("?fexit/do_exit") > +SEC("?fexit/task_exit") > int BPF_PROG(fexit_noreturns) > { > return 0; > diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > index fee479295e2f..7e00d8ecd110 100644 > --- a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > +++ b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc > @@ -82,7 +82,7 @@ check_error 'f vfs_read arg1=^' # NO_ARG_BODY > # multiprobe errors > if grep -q "Create/append/" README && grep -q "imm-value" README; then > echo "f:fprobes/testevent $FUNCTION_FORK" > dynamic_events > -check_error '^f:fprobes/testevent do_exit%return' # DIFF_PROBE_TYPE > +check_error '^f:fprobes/testevent task_exit%return' # DIFF_PROBE_TYPE > > # Explicitly use printf "%s" to not interpret \1 > printf "%s" "f:fprobes/testevent $FUNCTION_FORK abcd=\\1" > dynamic_events > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_multiprobe.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_multiprobe.tc > index f0d5b7777ed7..a95e3824690a 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_multiprobe.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_multiprobe.tc > @@ -5,7 +5,7 @@ > > # Choose 2 symbols for target > SYM1=$FUNCTION_FORK > -SYM2=do_exit > +SYM2=task_exit > EVENT_NAME=kprobes/testevent > > DEF1="p:$EVENT_NAME $SYM1" > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > index 8f1c58f0c239..b55ea3c05cfa 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc > @@ -87,7 +87,7 @@ esac > # multiprobe errors > if grep -q "Create/append/" README && grep -q "imm-value" README; then > echo "p:kprobes/testevent $FUNCTION_FORK" > kprobe_events > -check_error '^r:kprobes/testevent do_exit' # DIFF_PROBE_TYPE > +check_error '^r:kprobes/testevent task_exit' # DIFF_PROBE_TYPE > > # Explicitly use printf "%s" to not interpret \1 > printf "%s" "p:kprobes/testevent $FUNCTION_FORK abcd=\\1" > kprobe_events These tests need to pass on old kernels too. So we can't just do a "s/do_exit/task_exit/" conversion. It needs to test for task_exit first, and if not found, fallback to do_exit. See how we handled the _do_fork() > kernel_clone() rename: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/test.d/functions#n182 -- Steve