Re: [RFC PATCH 4/5] audit: add a missing function definition when !CONFIG_AUDIT

On Mon, Jul 27, 2026 at 2:02=E2=80=AFPM Ricardo Robaina <[email protected]=
m> wrote:
> On Fri, Jul 24, 2026 at 4:57=E2=80=AFPM Paul Moore <[email protected]> =
wrote:
> >
> > The audit_string_contains_control() function does not have a dummy
> > function definition in the !CONFIG_AUDIT case.
> >
> > Signed-off-by: Paul Moore <[email protected]>
> > ---
> >  include/linux/audit.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/include/linux/audit.h b/include/linux/audit.h
> > index d327113c913d..ac8f5f77d442 100644
> > --- a/include/linux/audit.h
> > +++ b/include/linux/audit.h
> > @@ -237,6 +237,10 @@ void audit_log_format(struct audit_buffer *ab, con=
st char *fmt, ...)
> >  { }
> >  static inline void audit_log_end(struct audit_buffer *ab)
> >  { }
> > +static inline bool audit_string_contains_control(const char *string, i=
nt len);
> > +{
> > +       return false;
> > +}
>
> Hi Paul,
>
> I noticed a stray semicolon here. Otherwise, it looks good.
>
> Reviewed-by: Ricardo Robaina <[email protected]>

Good catch, thanks!

--=20
paul-moore.com