Re: [PATCH 1/2] audit: drop BUG_ON() from audit_add_to_parent()

Ricardo Robaina <[email protected]> Tue, 28 Jul 2026 18:45:25 -0400

Newsgroups	org.kernel.vger.audit,org.kernel.vger.linux-kernel
Message-ID	<CAABTaaD3QG-ejOzuP6xC1yBM+jK23WQ_MgsC-HYBb93=wR-7FA@mail.gmail.com>

On Tue, Jul 28, 2026 at 3:53=E2=80=AFPM Paul Moore <[email protected]> wr=
ote:
>
> On Jul 28, 2026 Ricardo Robaina <[email protected]> wrote:
> >
> > The BUG_ON(!mutex_is_locked(&audit_filter_mutex)) check in
> > audit_add_to_parent() will panic the kernel if the mutex is not held,
> > which is too severe for this situation.
> >
> > Replace it with lockdep_assert_held(), instead.
> >
> > Signed-off-by: Ricardo Robaina <[email protected]>
> > ---
> >  kernel/audit_watch.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Merged into audit/dev, thanks.
>
> --
> paul-moore.com
>

Thanks, Paul!