Re: [PATCH 33/61] hfs: update format strings for u64 i_ino
Viacheslav Dubeyko <[email protected]> Thu, 26 Feb 2026 19:33:37 +0000
| Newsgroups | org.kernel.vger.autofs,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.infradead.lists.linux-mtd,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 2026-02-26 at 10:55 -0500, Jeff Layton wrote: > Update format strings and local variable types in hfs for the > i_ino type change from unsigned long to u64. > > Signed-off-by: Jeff Layton <[email protected]> > --- > fs/hfs/catalog.c | 2 +- > fs/hfs/extent.c | 4 ++-- > fs/hfs/inode.c | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c > index b80ba40e38776123759df4b85c7f65daa19c6436..7f5339ee57c15aae2d5d00474133a985be3af6ca 100644 > --- a/fs/hfs/catalog.c > +++ b/fs/hfs/catalog.c > @@ -417,7 +417,7 @@ int hfs_cat_move(u32 cnid, struct inode *src_dir, const struct qstr *src_name, > int entry_size, type; > int err; > > - hfs_dbg("cnid %u - (ino %lu, name %s) - (ino %lu, name %s)\n", > + hfs_dbg("cnid %u - (ino %llu, name %s) - (ino %llu, name %s)\n", > cnid, src_dir->i_ino, src_name->name, > dst_dir->i_ino, dst_name->name); > sb = src_dir->i_sb; > diff --git a/fs/hfs/extent.c b/fs/hfs/extent.c > index a097908b269d0ad1575847dd01d6d4a4538262bf..f066a99a863bc739948aac921bc906874c6009b2 100644 > --- a/fs/hfs/extent.c > +++ b/fs/hfs/extent.c > @@ -411,7 +411,7 @@ int hfs_extend_file(struct inode *inode) > goto out; > } > > - hfs_dbg("ino %lu, start %u, len %u\n", inode->i_ino, start, len); > + hfs_dbg("ino %llu, start %u, len %u\n", inode->i_ino, start, len); > if (HFS_I(inode)->alloc_blocks == HFS_I(inode)->first_blocks) { > if (!HFS_I(inode)->first_blocks) { > hfs_dbg("first_extent: start %u, len %u\n", > @@ -482,7 +482,7 @@ void hfs_file_truncate(struct inode *inode) > u32 size; > int res; > > - hfs_dbg("ino %lu, phys_size %llu -> i_size %llu\n", > + hfs_dbg("ino %llu, phys_size %llu -> i_size %llu\n", > inode->i_ino, (long long)HFS_I(inode)->phys_size, > inode->i_size); > if (inode->i_size > HFS_I(inode)->phys_size) { > diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c > index 878535db64d679995cd1f5c215f56c5258c3c720..95f0333a608b0fb57239cf5eec7d9489a25efb3a 100644 > --- a/fs/hfs/inode.c > +++ b/fs/hfs/inode.c > @@ -270,7 +270,7 @@ void hfs_delete_inode(struct inode *inode) > { > struct super_block *sb = inode->i_sb; > > - hfs_dbg("ino %lu\n", inode->i_ino); > + hfs_dbg("ino %llu\n", inode->i_ino); > if (S_ISDIR(inode->i_mode)) { > atomic64_dec(&HFS_SB(sb)->folder_count); > if (HFS_I(inode)->cat_key.ParID == cpu_to_be32(HFS_ROOT_CNID)) > @@ -455,7 +455,7 @@ int hfs_write_inode(struct inode *inode, struct writeback_control *wbc) > hfs_cat_rec rec; > int res; > > - hfs_dbg("ino %lu\n", inode->i_ino); > + hfs_dbg("ino %llu\n", inode->i_ino); > res = hfs_ext_write_extent(inode); > if (res) > return res; Looks good. Reviewed-by: Viacheslav Dubeyko <[email protected]> Thanks, Slava.