Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro
Christoph Hellwig <[email protected]> Tue, 3 Mar 2026 05:36:38 -0800
| Newsgroups | org.kernel.vger.autofs,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Mar 02, 2026 at 08:25:46PM -0800, Darrick J. Wong wrote: > > That being said, the userspace PRIu64, et. al macros are complete > > format specifiers, not just a length modifier. And I think this > > results in less ugly format specifiers in our kernel code. > > Yeah, I don't like "ino=%" PRIino "u, lolz\n" either. I'd rather have > the whole format in the PRIino definition -- it /is/ unsigned long > after all. Just drop the bloody macro and the pointless micro-splitting of the change. After this the inode is always 64-bit and we can just use normal ll specifiers without messing things up.