Re: [PATCH v2 000/110] vfs: change inode->i_ino from unsigned long to u64
NeilBrown <[email protected]> Wed, 04 Mar 2026 17:26:59 +1100
| Newsgroups | org.kernel.vger.autofs,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 03 Mar 2026, Jeff Layton wrote: > On Tue, 2026-03-03 at 10:55 +0000, David Howells wrote: > > Jeff Layton <[email protected]> wrote: > > > > > This version splits the change up to be more bisectable. It first adds a > > > new kino_t typedef and a new "PRIino" macro to hold the width specifier > > > for format strings. The conversion is done, and then everything is > > > changed to remove the new macro and typedef. > > > > Why remove the typedef? It might be better to keep it. > > > > Why? After this change, internel kernel inodes will be u64's -- full > stop. I don't see what the macro or typedef will buy us at that point. Implicit documentation? ktime_t is (now) always s64, but we still keep the typedef; It would be cool if we could teach vsprintf to understand some new specifier to mean "kinode_t" or "ktime_t" etc. But that would trigger gcc warnings. NeilBrown