Re: [PATCH v3 01/12] vfs: widen inode hash/lookup functions to u64
Christian Brauner <[email protected]> Fri, 6 Mar 2026 14:28:59 +0100
| Newsgroups | org.kernel.vger.autofs,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <20260306-klauen-aufruf-3f79ec9cd4cb@brauner> |
On Fri, Mar 06, 2026 at 07:03:15AM -0500, Jeff Layton wrote: > On Thu, 2026-03-05 at 06:24 -0800, Christoph Hellwig wrote: > > > extern struct inode *ilookup5_nowait(struct super_block *sb, > > > - unsigned long hashval, int (*test)(struct inode *, void *), > > > + u64 hashval, int (*test)(struct inode *, void *), > > > void *data, bool *isnew); > > > -extern struct inode *ilookup5(struct super_block *sb, unsigned long hashval, > > > +extern struct inode *ilookup5(struct super_block *sb, u64 hashval, > > > int (*test)(struct inode *, void *), void *data); > > > > ... > > > > Can you please drop all these pointless externs while you're at it? > > > > I was planning to do that, but then Christian merged it! > > I'll do a patch on top of this that does this in the range of fs.h that > the patch touches. Christian can throw it on top of the series, and > that shouldn't be too bad for backports. I can easily drop those so no need to resend for stuff like this as per the usual protocol.