Re: [PATCH 3/3] backports: Add kvcalloc()

On Tue, 2019-11-19 at 20:12 +0100, Hauke Mehrtens wrote:
> On 11/19/19 9:59 AM, Johannes Berg wrote:
> > On Sat, 2019-11-16 at 19:36 +0100, Hauke Mehrtens wrote:
> > > kvcalloc() was added in kernel commit 1c542f38ab8d ("mm: Introduce
> > > kvcalloc()") and is now used by the fq header filers.
> > 
> > Oops, I did the same some time ago but forgot to send it out.
> > 
> > > +{
> > > +	return kvmalloc_array(n, size, flags | __GFP_ZERO);
> > 
> > I did end up wondering though if __GFP_ZERO actually worked on all old
> > kernels?
> 
> __GFP_ZERO is at least defined on old kernel versions. I haven't seen an
> error when building against 3.14 for example and it is already used
> somewhere else in this file.

I know. I just have a vague recollection it didn't always work for any
kind of allocation. I guess I should go search tomorrow...

johannes

--
To unsubscribe from this list: send the line "unsubscribe backports" in