Re: [PATCH v2 2/2] backports: add skb_list_del_init
Felix Fietkau <[email protected]>
| Newsgroups | org.kernel.vger.backports |
|---|---|
| Message-ID | <[email protected]> |
On 2020-08-31 20:46, Hauke Mehrtens wrote: > On 8/14/20 4:29 PM, Felix Fietkau wrote: >> It is needed for mac80211 >> >> Signed-off-by: Felix Fietkau <[email protected]> >> --- >> backport/backport-include/linux/skbuff.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/backport/backport-include/linux/skbuff.h b/backport/backport-include/linux/skbuff.h >> index 3ed990d0d2ef..7b825630d391 100644 >> --- a/backport/backport-include/linux/skbuff.h >> +++ b/backport/backport-include/linux/skbuff.h >> @@ -384,6 +384,12 @@ static inline void skb_mark_not_on_list(struct sk_buff *skb) >> { >> skb->next = NULL; >> } >> + >> +static inline void skb_list_del_init(struct sk_buff *skb) >> +{ >> + __list_del_entry(&skb->list); >> + skb_mark_not_on_list(skb); >> +} >> #endif /* 4.19.10 <= x < 4.20 */ >> #endif >> >> > > Hi Felix, > > These two backports are not working. > > The list member was only added in kernel 4.19 to the sk_buff structure, > see here: > https://git.kernel.org/linus/d4546c2509b1e9cd082e3682dcec98472e37ee5a I guess it was working for me on 4.14 because the list member was backported in 4.14.71. So it works for kernels with that backport, and I guess other versions which don't have that will need a more intrusive backport that patches mac80211 anyway. - Felix -- To unsubscribe from this list: send the line "unsubscribe backports" in