Re: [PATCH bpf-next 1/5] bpf: do not print a newline after disassembly in bpf_verbose_insn()

On Fri, 2026-07-31 at 20:24 +0000, [email protected] wrote:
> > diff --git a/tools/bpf/bpftool/xlated_dumper.c b/tools/bpf/bpftool/xlated_dumper.c
> > index 5e7cb8b36fef2..7b33d847d800c 100644
> > --- a/tools/bpf/bpftool/xlated_dumper.c
> > +++ b/tools/bpf/bpftool/xlated_dumper.c
> 
> [ ... ]
> 
> > @@ -417,6 +412,7 @@ void dump_xlated_for_graph(struct dump_data *dd, void *buf_start, void *buf_end,
> > 
> >  		printf("%u: ", insn_off);
> >  		print_bpf_insn(&cbs, cur, true);
> > +		printf("\\l\\\n");
> > 
> >  		if (opcodes) {
> >  			printf("\\ \\ \\ \\ ");
> 
> This isn't a bug, but now that no disasm.c format string carries a
> newline and dump_xlated_for_graph() emits "\\l\\\n" itself, is the
> '\n' arm of print_insn_for_graph() still reachable?

It is a dead code and it should be removed.

...