Re: [PATCH bpf-next v3 1/5] bpf: do not print a newline after disassembly in bpf_verbose_insn()

On 02/08/2026 21:24, Eduard Zingerman wrote:
> At the moment there are more callsites that want bpf_verbose_insn() to
> not print a newline after the instruction, than callsites that want a
> newline. Drop '\n' from disasm.c. Non-functional change.
> 
> The changes in bpftool are verified by writing a bpf program using a
> variety of instructions and comparing `prog dump xlated` output in the
> following modes: plain, opcodes, visual, visual opcodes.
> The output before and after the changes is identical.
> 
> Cc: Quentin Monnet <[email protected]>
> Signed-off-by: Eduard Zingerman <[email protected]>


Looks good, and looking at the diff, the change makes sense. Thanks!

Reviewed-by: Quentin Monnet <[email protected]>