Re: [PATCH net v2] selftests: net: reuseport_bpf_numa: consider cpuless numa node
[email protected] Tue, 04 Aug 2026 01:42:30 +0000
| Newsgroups | org.kernel.vger.bpf |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Spelling mistake in newly added comment: 'unlikeyly' instead of 'un= likely'. -- --- Patch [1]: [PATCH net v2] selftests: net: reuseport_bpf_numa: consider = cpuless numa node --- commit 4e53579a82f841c838d35fa42c245feb267f6bcb Author: Feng Tang <[email protected]> selftests: net: reuseport_bpf_numa: consider cpuless numa node This commit fixes a test failure on platforms with CXL memory where a NUMA node might only have memory and no CPUs. It adds a sanity check to skip cpuless NUMA nodes during the NUMA binding test to prevent numa_run_on_node() from failing. > diff --git a/tools/testing/selftests/net/reuseport_bpf_numa.c b/tools/tes= ting/selftests/net/reuseport_bpf_numa.c > index 8ec52fc5ef41b..b5fb576fa61af 100644 > --- a/tools/testing/selftests/net/reuseport_bpf_numa.c > +++ b/tools/testing/selftests/net/reuseport_bpf_numa.c [ ... ] > +/* > + * Return true if it is a cpuless node. Return false if it isn't or any > + * error (very unlikeyly) happens during the libnuma calls. [Severity: Low] This isn't a bug, but there is a typo here: "unlikeyly" instead of "unlikely". > + */ > +static inline bool is_cpuless_node(int node_id) > +{ > + struct bitmask *cpumask; > + bool ret =3D false; [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260803014214.8074= [email protected]?part=3D1