RE: [PATCH v4 net-next 1/1] net: update comments for SKB_GSO_TCP_ECN and SKB_GSO_TCP_ACCECN

> -----Original Message-----
> From: Jakub Kicinski <[email protected]>=20
> Sent: Tuesday, August 4, 2026 2:47 AM
> To: Chia-Yu Chang (Nokia) <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];=
 [email protected]; [email protected]; [email protected]=
; [email protected]; [email protected]; [email protected]; corbet=
@lwn.net; [email protected]; [email protected]; [email protected]; bpf@vger=
.kernel.org; [email protected]; [email protected]; [email protected];=
 [email protected]; [email protected]; [email protected]; da=
[email protected]; [email protected]; [email protected]; ast@fibe=
rby.net; [email protected]; [email protected]; [email protected]=
l.org; [email protected]; [email protected]; Koen De Schepper (Nokia) <koen.=
[email protected]>; [email protected]; ingemar.s.johansso=
[email protected]; [email protected]; [email protected]; rs.ietf@=
gmx.at; [email protected]; [email protected]; Parav Pandit <pa=
[email protected]>
> Subject: Re: [PATCH v4 net-next 1/1] net: update comments for SKB_GSO_TCP=
_ECN and SKB_GSO_TCP_ACCECN
>=20
>=20
> CAUTION: This is an external email. Please be very careful when clicking =
links or opening attachments. See the URL nok.it/ext for additional informa=
tion.
>=20
>=20
>=20
> On Tue, 28 Jul 2026 18:10:07 +0200 [email protected]
> wrote:
> > For RX, SKB_GSO_TCP_ECN shall NOT be used
>=20
> but it _is_ still used in hns3, what's your plan there?
> Documenting something we adhere to at the outset seems like a red flag.
>=20
Hello,

I would think to remove the SKB_GSO_TCP_ECN in hns3.
Because hns3 will break the whole TOS byte based on Jijie's email: https://=
lore.kernel.org/all/[email protected]/#t

Also, the virtio related changes will be submitted only after the approval =
from virtio-spec.

Thanks.
Chia-Yu