Re: [PATCH v8 13/25] cachefiles,netfs: sunset ondemand mode

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:
- [Low] The `unbind_pincount` refcount logic and `cachefiles_get_unbind_pin=
count()` are obsolete and represent dead code that was not cleaned up.
--

--- Patch [13]: [PATCH v8 13/25] cachefiles,netfs: sunset ondemand mode ---
(Note: The format of this report is altered to a free-form summary due to r=
estrictions on quoting the original patch text.)

commit c6195bde7925bad759ef9b523809694f0463c1c2
Author: Gao Xiang <[email protected]>
Subject: cachefiles,netfs: sunset ondemand mode

This commit removes the fscache on-demand read mode since EROFS over fscache
is no longer used. It removes the ondemand.c file, the associated uapi head=
er,
and cleans up the daemon and interface code previously supporting this mode.

Link: https://lore.kernel.org/r/CAOQ4uxi4dzxArY24YO=3D+kBCK2gGoq3Ptb8WkzCqS=
[email protected]
Link: https://sashiko.dev/#/patchset/20260716103030.3065561-1-dhowells%40re=
dhat.com
Link: https://sashiko.dev/#/patchset/20260722130218.78958-1-dhowells%40redh=
at.com

[Severity: Low]
With the removal of the on-demand read mode, it looks like the unbind_pinco=
unt
tracking in struct cachefiles_cache (defined in fs/cachefiles/internal.h) w=
as
left behind as dead code.=20

Because cachefiles_get_unbind_pincount() in fs/cachefiles/daemon.c is now
completely unused, and cachefiles_put_unbind_pincount() is only ever called
once per daemon lifecycle during release, is this atomic refcount still
necessary?=20

Could we completely remove unbind_pincount and its associated helper functi=
ons
to finish cleaning up the dead code left over from the ondemand mode?

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260804100224.2748=
[email protected]?part=3D13